#linuxcnc Logs

Dec 08 2018

02:08 AM Deejay: moin
04:47 AM jthornton: morning
04:47 AM Deejay: hey
04:49 AM XXCoder: hey jthornton
05:06 AM jthornton: what's up today?
05:07 AM XXCoder: not much just played with wii u some and pondered a bit on disapperance of my doc change
05:07 AM XXCoder: i pushed 3 very minor changes and i cant find it anywhere
05:08 AM jthornton: I don't see any log of a push on the devel channel
05:09 AM XXCoder: i just directly edited file on git (it was very simple) and added umm request i think pull request? forgot
05:09 AM jthornton: ah someone has to react to a pull request
05:10 AM XXCoder: i see pull list and none of em is by me
05:10 AM XXCoder: nov 26th something I think
05:13 AM MarcelineVQ: what's your git name
05:13 AM XXCoder: rredford
05:15 AM MarcelineVQ: what was the branch you were working on called?
05:16 AM XXCoder: thats the sad thing, i cant remember but is there a way to show my activity history in any git?
05:18 AM MarcelineVQ: dunno, but you're not in any closed or open pr's https://github.com/LinuxCNC/linuxcnc/pulls?utf8=✓&q=rredford
05:18 AM XXCoder: bah no iea what happened then
05:19 AM XXCoder: what I did is just edit 2 files then made file change request somehow
05:19 AM XXCoder: probably failed to finalize it or something
05:20 AM MarcelineVQ: on github you make your changes on a branch, push to that branch on your own repo, then make a pull request to linuxcnc for them to pull your branch from your repo
05:22 AM MarcelineVQ: if you could remember what you called your branch that you were making changes on you could at least confirm if you pushed it to your own repo
05:23 AM XXCoder: it dont really matter can always do it agaim its literally just 4 words total change
05:23 AM jthornton: I need to get this new PC setup to push this morning
05:23 AM XXCoder: add rolfmill to vismach sim machines list, change rolfmill.hal for comments to "most comments is in rolfmill, and some in rolfmill.hal"
05:24 AM XXCoder: not exact words I used but you get the idea
05:24 AM jthornton: rolfmill is in the sim axis vismach
05:24 AM XXCoder: yeah but doc is missing it
05:25 AM jthornton: where are the sim's listed in the documents?
05:25 AM XXCoder: lemme re-find it again
05:26 AM XXCoder: https://github.com/LinuxCNC/linuxcnc/tree/master/configs/sim/axis
05:26 AM XXCoder: one of 3 I think lemme find others
05:26 AM XXCoder: no not that one
05:27 AM XXCoder: https://github.com/LinuxCNC/linuxcnc/tree/master/configs/sim/axis/vismach
05:27 AM XXCoder: i just added -- rolfmill at end
05:27 AM XXCoder: and in https://github.com/LinuxCNC/linuxcnc/tree/master/configs/sim/axis/vismach/rolfmill change "Comments in rolfmill.hal explain step by step the process to build." to "Comments is in rolfmill, and some in rolfmill.hal explain step by step the process to build.
05:28 AM MarcelineVQ: what does is in rolfmill mean?
05:28 AM XXCoder: MarcelineVQ: rolfmill is vismach file
05:28 AM XXCoder: its the file that has HUGE amount of comments
05:28 AM XXCoder: https://github.com/LinuxCNC/linuxcnc/blob/master/configs/sim/axis/vismach/rolfmill/rolfmill enjoy
05:28 AM jthornton: yea it's really a bad description and should be more descriptive of what it is
05:28 AM MarcelineVQ: best to mention that then so people don't have to ask :>
05:29 AM XXCoder: hmm yeah "in rolfmach vismach file, and some in rolfmill.hal"
05:29 AM XXCoder: more clear?
05:30 AM XXCoder: let me try edit the readme again see step by step if I did it correctly
05:30 AM MarcelineVQ: yes
05:30 AM XXCoder: ah!
05:30 AM XXCoder: "edit the file in your fork"
05:30 AM XXCoder: guess it clones it to my git when i do
05:30 AM XXCoder: lemme see same file in my copy
05:30 AM jthornton: I still don't see where your saying it is in the documents
05:31 AM XXCoder: nope file is same there also. weird
05:31 AM jthornton: ah I see what your talking about the vismach readme doesn't mention it
05:31 AM XXCoder: jt let me try something tho
05:31 AM XXCoder: im now editing my copy
05:32 AM XXCoder: then see if can pull
05:32 AM jthornton: you really should name it 3-axis-mill or similar
05:33 AM XXCoder: i suppose. yeah. though I think if someone tries to use it, it'll be either broken or create rolf folder in usr
05:33 AM XXCoder: because one of config points to my folder
05:34 AM jthornton: yea I'll fix that
05:34 AM XXCoder: do I add my name in comment or what? saw some configs have that
05:34 AM XXCoder: i just left it rolfmill because i named it when I was building it
05:35 AM XXCoder: maybe tutoral-vismach ?
05:35 AM jthornton: I understand that
05:36 AM XXCoder: is that name workable?
05:38 AM jthornton: I think that should be in the readme and I need to expand that a bit the name should describe the configuration
05:38 AM XXCoder: it'd make name bit long maybe just 3axis-tutoral
05:39 AM jthornton: gotta do some hard drive swapping to get back to where I was working before adding the new pc
05:43 AM XXCoder: damn
05:43 AM XXCoder: cant recall how to do git pull into my pc
05:43 AM XXCoder: so I can make few changes before update then do pull request
05:43 AM XXCoder: been too long
05:44 AM XXCoder: whew heh also thanks
05:45 AM MarcelineVQ: you typically want to clone your own github fork so you can update it independantly, and it makes PR's straightforward
05:45 AM XXCoder: marc yeah thats what I am doing now
05:45 AM XXCoder: cloned my repo not master
05:46 AM XXCoder: what you think of 3axis-tutoral name?
05:46 AM MarcelineVQ: for?
05:46 AM XXCoder: name of vismach
05:47 AM XXCoder: specifically one currently named rolfmill
05:47 AM MarcelineVQ: If that's what it is then it's a good name, don't know anything about it
05:47 AM XXCoder: ok
05:48 AM jthornton: I think that would make more sense if there was a chapter in the documents called vismach tutorial
05:49 AM jthornton: and that is not a bad idea...
05:49 AM XXCoder: yeah
05:49 AM Tom_L: it might attract more attention if it was named what it did for sure
05:49 AM MarcelineVQ: there is a bit of one here http://linuxcnc.org/docs/devel/html/gui/vismach.html
05:49 AM XXCoder: i noticed something though, vismach fules is not in same directory as HAL files
05:50 AM XXCoder: think its in /usr/bin folder but i dont know where thats located in source
05:51 AM XXCoder: ah i think i found it
05:51 AM XXCoder: nope
05:52 AM jthornton: yea the sims became a pia when they hid all the files and made everything a simlink you can't even copy... rambling off
05:52 AM XXCoder: eh as well as leave it there so people can copy
05:52 AM XXCoder: anyway
05:52 AM XXCoder: now working on naming
05:53 AM jthornton: rambling back on and being forced to make a copy of a sim just to look at it is dumb
05:54 AM XXCoder: -- 3axis-tutoral: vismach that have comments in 3axis-tutoral as well as 3axis-tutoral.hal in order to show you how to build your own machine and use it.
05:54 AM XXCoder: what you think
05:55 AM jthornton: I think the sim name should be 3axis-mill and the tutorial part should be in the readme as well as a chapter vismach tutorial
05:56 AM * Tom_L waits for the dust to settle
05:57 AM jthornton: did you get any snow? we are supposed to get some this afternoon
05:58 AM Tom_L: they put brine on all the roads.... false alarm
05:59 AM Tom_L: it all stayed in Ok it appears
05:59 AM Tom_L: looks like you're right on the edge of it
05:59 AM XXCoder: okay! renaming is done
05:59 AM XXCoder: lets see if it even runs
06:01 AM XXCoder: its 2.8 version lol
06:03 AM XXCoder: jthornton: can you pull and test before confirming it?
06:03 AM XXCoder: if not ill find a way to get 2.8 to test with
06:03 AM jthornton: I don't know anything about PR's
06:04 AM XXCoder: 2.7 and 2.8 is bit different so not sure how to change both versions
06:05 AM jthornton: yea the configs are different for each one
06:05 AM XXCoder: i renamed folder, files and edited files to point to correct files
06:05 AM XXCoder: added creator comment to vismach file
06:06 AM XXCoder: i dont want to do a untested pull
06:07 AM jthornton: unless you have push rights you can't push your changes so what ever you do is safe
06:07 AM XXCoder: yeah as well as push it to my version
06:07 AM XXCoder: so git comment? how do I update files list?
06:08 AM jthornton: did you mean git commit? or comment?
06:08 AM XXCoder: commit sorry
06:09 AM MarcelineVQ: by update files list do you mean add changed files to a commit?
06:09 AM jthornton: commit just saves the changes to your local copy
06:09 AM XXCoder: ok git status shows one file changed and 5 files deleted
06:09 AM XXCoder: not surpised. need to add new name folder and files
06:09 AM XXCoder: it also tells me how to. nice
06:10 AM XXCoder: okay now it has new files
06:11 AM XXCoder: ok now its "renamed" nice
06:11 AM XXCoder: been so long lol
06:14 AM XXCoder: dammit mispelled tutorial so i have to do it all over
06:14 AM MarcelineVQ: just make another commit with your changes
06:14 AM XXCoder: nah havent commented
06:14 AM XXCoder: *commited
06:15 AM MarcelineVQ: I also use git rebase -i to combine multiple changes before pushing, but never rebase someone else's commits, only your own if you have a few in a row
06:17 AM MarcelineVQ: you can try git rebase -i HEAD~4 to see an example of what I mean by that. just exit without changing anything
06:19 AM XXCoder: okay re-rename is done lol
06:20 AM XXCoder: okay git commit how do I push it to git repo?
06:21 AM MarcelineVQ: it depends what your remotes are, what does git remote -v say
06:22 AM XXCoder: it lists my git version of linuxcnc repo
06:22 AM XXCoder: fetch then push
06:22 AM MarcelineVQ: if it only has yours or it says origin is yours git push is fine
06:24 AM XXCoder: warning: push.default is unset; its implicit value ha....
06:25 AM XXCoder: oh nm
06:25 AM MarcelineVQ: if it doesn't work try git push origin assuming origin is what remove says your own repo was called
06:25 AM XXCoder: a second
06:25 AM MarcelineVQ: When successful the new branch should show up at the top of your forked linuxcnc repo, there might even be a link to make a PR from it at the same time, I can't recall
06:25 AM MarcelineVQ: *what remote says your own repo is called
06:26 AM XXCoder: ya just needed to login
06:27 AM XXCoder: https://github.com/rredford/linuxcnc/commit/bf07cb5e95780b48513a4025cdf7d36fcab952ff
06:28 AM MarcelineVQ: what's this? https://github.com/rredford/linuxcnc/commit/bf07cb5e95780b48513a4025cdf7d36fcab952ff#diff-fc0e59ca6b7e92c8ff6851a26583f0fbR45
06:28 AM XXCoder: line 45?
06:28 AM MarcelineVQ: yes
06:28 AM XXCoder: its efault directory when you want open nc files
06:29 AM XXCoder: it should be example nc files
06:30 AM XXCoder: folder
06:31 AM MarcelineVQ: ah hmm, is it made clear somewhere else that this will need to change? no one else will have /home/rolf hehe
06:31 AM XXCoder: indeed
06:31 AM XXCoder: no, jt is planning to change it once im done so i added comment to remind
06:31 AM XXCoder: i need to copy 2.7 version and change that one aksio
06:33 AM MarcelineVQ: heyyy wait a minute, this says master :( you didn't make a branch for these changes?
06:33 AM XXCoder: i havent changed linuxcnc git just my copy though not sure what to do atm
06:34 AM MarcelineVQ: You should always make a new branch when making changes you intend to do a PR with.
06:34 AM XXCoder: can I rename it to not master?
06:34 AM MarcelineVQ: No but you should be able to move this to a branch, lemme see..
06:34 AM XXCoder: yeah I see swiychj branches/tags
06:34 AM XXCoder: "find or create a branch"
06:34 AM XXCoder: switch
06:35 AM XXCoder: so what name would make sense?
06:35 AM XXCoder: i see stuff like andy-whatever
06:35 AM MarcelineVQ: basically you want to be on master and then git checkout -c mynewbranchname before you even start making changes, it's good practice, don't do that just now though
06:36 AM jthornton: yea usually the branch is your name-what-it-is
06:36 AM MarcelineVQ: You'll need to google how to move your commit to another branch, I'm not sure how to do that
06:36 AM XXCoder: rredford-3daxis-tutorial it is then
06:36 AM MarcelineVQ: it jthornton's going to make changes anyway you might just want to leave it, let him clone your repo, make the changes and do the PR
06:37 AM jthornton: MarcelineVQ: I have push rights but have never done a pr
06:37 AM MarcelineVQ: Like, no sense doing a PR, and then doing a PR to do one change
06:37 AM MarcelineVQ: Neither has XXCoder it sounds like hehe
06:38 AM XXCoder: i have had, but been years
06:38 AM MarcelineVQ: Not that I'm some expert, don't want to imply that
06:42 AM XXCoder: jthornton: should I just do pr?
06:50 AM jthornton: that's up to you, I don't know anything about pr's except what they are
06:54 AM * jthornton can't figure out where the mice are getting in the basement...
06:54 AM jthornton: shutting down for a bit...
06:54 AM XXCoder: doctor mouse who ;)
06:54 AM jthornton: just put out some sticky traps and mouse traps again...
07:07 AM XXCoder: wb
07:16 AM jthornton: thanks, one more hard drive to swap in a bit I hope
07:16 AM XXCoder: cool
07:18 AM jthornton: but first time to start a fire or two
07:38 AM weenerdog: howdy
08:17 AM JT-Shop: hey
08:18 AM weenerdog: they've jacked our forecast back up to 2'. i'm gonna go ahead and declare snowdefcon 2 and implement emergency spaghetti and apple cobbler making protycols :)
08:20 AM JT-Shop: lol
08:53 AM * Tom_L thinks JT-Shop is playing musical hdds
08:54 AM Tom_L: funny, we made spaghetti last night for the same reason
08:54 AM jthornton: no /me is playing musical hard drives
08:54 AM * jthornton needs to finish a project... any project I don't care just need to finish something lol
08:54 AM Tom_L: may swing by for some cobbler though :D
08:55 AM Tom_L: i've kinda been in limbo here too with no project to finish
08:59 AM jthornton: I have far too many started... I'll email you a few to finish lol
09:07 AM Tom_L: heh
09:08 AM Tom_L: the last data parse thing worked out good
09:08 AM Tom_L: stupid java
11:13 AM * flyback has witnessed muscial hdd's
11:13 AM flyback: some maxtors would pwm a tune out of the spindle when it was stuck
11:13 AM flyback: speaking of hdd's
11:14 AM flyback: I solved the issue on my data recovery box with a $5 old dell raid card
11:14 AM flyback: all the 3rd party ones didn't like this poweredge
11:14 AM flyback: I need 1 pata port for rescuing old pata hdd's 1 sata port for os 1 sata port for rescuing sata hd's and a temp raid array to copy the data too
11:18 AM * jthornton just gained 2 square feet of desk space :)
11:56 AM roycroft: you built an extension for your desk?
02:47 PM justanotheruser is now known as Guest39745
02:51 PM justan0theruser is now known as justanotheruser
03:38 PM Deejay: gn8
05:42 PM jthornton: yippie I got the 2TB drive formatted and changed the name from alsdfg-qgh=vmnrt89qywd9pfqyhf59qd8wtyg7802ybhtp89f2yh to data
05:47 PM XXCoder: my pull got approved
05:48 PM _unreal_: freaking amazing.. fandango has no provision for refunding... they claim they do but they dont.
05:48 PM _unreal_: XXCoder, pull?
05:48 PM XXCoder: yeah changed some files in linuxcnc
05:58 PM XXCoder: jthornton: know whats weird?
05:58 PM XXCoder: one file I changed didnt get commited and updated. somehow git missed it
06:03 PM _unreal_: I have been dreading this..... I just put my stepper motor chip into a PERF board
06:04 PM _unreal_: heating up the soldering iron. and preping to go at it
06:04 PM _unreal_: I have a bunch of sla702(4)(6)'s
06:05 PM jthornton: XXCoder: awesome your PR go approved
06:05 PM jthornton: that is odd
06:05 PM XXCoder: yeah
06:06 PM XXCoder: im not sure how to also fix 2.7 version
06:08 PM jthornton: normally I fix the lowest version then let a developer merge it so it stays clean
06:09 PM * jthornton goes to marinate the fajita meat
09:01 PM Contract_Pilot: Sup.
09:08 PM skunkworks: Contract_Pilot: long time no see?
09:08 PM Contract_Pilot: I been on and off..