#linuxcnc-devel Logs

May 13 2017

10:06 AM jepler: cradek: I bet the omitted information on that issue is "on a polish keyboard" and "angular jog rate", but that's just a guess since < and > are on a single key on the PL keyboard, the one that doesn't exist on US keyboards.
10:08 AM jepler: http://ascii-table.com/keyboard.php/214
12:37 PM cradek: jepler: excellent divination
01:47 PM seb_kuzminsky: jepler: the nightly flo reboot keeps killing the memory monitor
01:47 PM seb_kuzminsky: i wonder if your apache thread-count fix didn't resolve the memory overcommit problem
01:47 PM seb_kuzminsky: i'd be curious to see what happens if you stop rebooting it for a week or two
02:02 PM jepler: seb_kuzminsky: I can disable the reboot
02:02 PM jepler: .. done
02:14 PM skunkworks_: jepler, did the fix work?
02:14 PM skunkworks_: (v1)
03:10 PM seb_kuzminsky: jepler: i restarted the memory monitor
05:12 PM jepler: skunkworks_: no, only temporarily
05:22 PM skunkworks_: did you cut the end off? 1/4 inch or so?
05:25 PM jepler: no, I don't see how that's supposed to help tbh.
05:25 PM jepler: also not sure I have a good tool for cutting it flush
07:36 PM andypugh: I am confused
07:38 PM andypugh: Two bad memcpy lines around here: https://github.com/LinuxCNC/linuxcnc/blob/master/src/hal/drivers/mesa-hostmot2/sserial.c#L1531
07:38 PM andypugh: Click the file history: https://github.com/LinuxCNC/linuxcnc/commit/a1a347d14a562f3dc670ed005507b79ac394fc70
07:38 PM andypugh: There is the fix
07:39 PM andypugh: Why is that patch not showing in the code?
08:02 PM jepler: they are showing in my copy of the code at the tip of master branch
08:02 PM jepler: memcpy(&buff, &temp, sizeof(float));
08:05 PM jepler: oh I know why :-/
08:05 PM jepler: try looking at all the memcpy sites
08:06 PM jepler: e.g., try with your local copy
08:06 PM jepler: $ git grep memcpy -- src/hal/drivers/mesa-hostmot2/sserial.c
08:06 PM jepler: andypugh: ^^^
08:09 PM andypugh: Hmm. Missed some
08:10 PM andypugh: Someone was getting compiler warnings on the other lines.
08:10 PM andypugh: That’s the confusing part.
08:55 PM KGB-linuxcnc: 03andy pugh 05master d63aca6 06linuxcnc 10src/hal/drivers/mesa-hostmot2/sserial.c Fix the other half of a1a347d1 * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=d63aca6