#hazzy Logs

Jun 11 2020

#hazzy Calendar

07:09 AM Lcvette: morning
07:11 AM JT-Cave: morning
08:02 AM TurBoss: hello
09:27 AM Not-944e: [02qtpyvcp] 07hadcom opened issue 03#38: AttributeError: 'Status' object has no attribute 'backplot_gcode_error' - 13https://git.io/Jf9Rd
04:20 PM Lcvette: o/
04:27 PM Lcvette: JT are you running linuxcnc on your lathe?
04:46 PM * JT[m] uploaded an image: VectorImage_2020-06-11_043553.jpg (8195KB) < https://matrix.org/_matrix/media/r0/download/matrix.org/kSSwdUGyYJgMZZmIFpjjzrZg >
04:46 PM JT[m]: Lcvette yes
04:47 PM JT[m]: Assuming you're talking about the CHNC and not the Samson lol
04:48 PM Joco[m]1: FRIDAY!!
04:54 PM Lcvette: JT: do you use a master tool method for tool offsets?
04:54 PM Lcvette: im new to lathes and trying to sort out what i need to do to setup my tools
04:59 PM JT[m]: I have an 8 station turret
05:01 PM JT[m]: I set the XZ offset when I put a tool in the holder, no repeatability when changing tools
05:02 PM JT[m]: Tool 1 I use to set Z for the material
05:03 PM JT[m]: I set Z tool offset on the face of the spindle
07:40 PM lmclaren[m]1: Hi, I am new to this but am I correct in thinking that https://github.com/kcjengr/qtpyvcp/pull/37 has not been merged into trunk yet?
07:46 PM hazzy-m1: lmclaren: correct
07:47 PM hazzy-m1: lmclaren: were you the one that needed the HAL pins?
07:47 PM lmclaren[m]1: @haz
07:48 PM lmclaren[m]1: yes
07:48 PM lmclaren[m]1: Does it need to wait for a feature rollup before it will be merged?
07:49 PM lmclaren[m]1: not pushing, I understand that people are doing this on their own free time
07:50 PM hazzy-m1: I'm not real comfortable with that being in the main application code. The exposed HAL pins should at lease be defined in a separate module, and preferably in a plugin so they can be added or modified on a per VCP basis if needed
07:52 PM hazzy-m1: lmclaren: have you created your own VCP, or using one of the standard ones like ProbeBasic?
07:52 PM lmclaren[m]1: I am using probebasic
08:16 PM hazzy-m1: ok
08:16 PM * hazzy-m1 uploaded an image: image.png (37KB) < https://matrix.org/_matrix/media/r0/download/matrix.org/jXJmVCUDEXNZIFNJTuEeKxgh >
08:16 PM hazzy-m1: syntax highlighting is working again!
08:21 PM Joco[m]1: <hazzy-m1 "I'm not real comfortable with th"> If the Hal pins were VCP specific I agree. But are these ones not just exposing fundamental capability’s within the LinuxCNC python binding?
08:22 PM Joco[m]1: Or do you really just want anything Hal related in a separate module, period?
08:32 PM hazzy-m1: The HAL pins you have added are exposing the QtPyVCP actions as HAL pins, which is good, but I don't think that belongs in application.py, since it makes the entirety of QtPyVCP dependent on the LinuxCNC specific actions, which might not always be available in that way (for instance a remote interface, or QtPyVCP used for something other than a LinuxCNC interface)
08:33 PM hazzy-m1: I think those HAL pins should probably be exposed in the same location that the actions are defined, or in a plugin
08:38 PM Joco[m]1: will have a look at how to expose with actions. Not sure when will get to it. Now that NZ is about back to normal not go anywhere near the spare time.
08:39 PM Not-944e: [02qtpyvcp] 07joco-nz commented on pull request 03#37: Expose override reset pins - cheerypick - 13https://git.io/Jf95h
08:39 PM Not-944e: [02qtpyvcp] 07joco-nz closed pull request 03#37: Expose override reset pins - cheerypick - 13https://git.io/Jfwmw
08:42 PM hazzy-m1: I'm not sure when the actions module gets imported first, if it gets imported before the hal comp is created it might be a pain
08:42 PM hazzy-m1: really need to move actions to a plugin so we have control of the order everything is loaded in
08:44 PM hazzy-m1: I was temped to merge what you did since it works, and reconsider later, but am suffering from paralyses by analysis
08:48 PM Joco[m]1: lol
08:48 PM Joco[m]1: decision made. pulled the pull ;-)
08:49 PM Joco[m]1: off to find some lunhc