Back
[05:41:39] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15ikcalB opened pull request #89: twopass.tcl: updated for personalities & loadusr on pass0 (06master...06master) 02
https://github.com/LinuxCNC/linuxcnc/pull/89
[05:49:08] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15ikcalB commented on issue #89: Doh! I sent the pull request against master, but this is applicable to 2.7 at least, maybe even 2.6.... 02
https://github.com/LinuxCNC/linuxcnc/pull/89#issuecomment-229010556
[05:49:38] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15ikcalB commented on issue #89: Doh! I sent the pull request against master, but this is applicable to 2.7 at least, probably even 2.6.... 02
https://github.com/LinuxCNC/linuxcnc/pull/89#issuecomment-229010556
[07:31:46] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15jepler commented on issue #89: On first glance, I think the change regarding personality= is probably uncontroversial.... 02
https://github.com/LinuxCNC/linuxcnc/pull/89#issuecomment-229029535
[09:48:27] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15ikcalB commented on issue #89: I didn't know about the sampler, my fault. That's why I should have made 2 seperate pull requests beforehand.... 02
https://github.com/LinuxCNC/linuxcnc/pull/89#issuecomment-229064020
[10:10:01] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15ikcalB opened pull request #90: twopass.tcl: add support for `personalities` of kernel modules (06master...06tp-personalities) 02
https://github.com/LinuxCNC/linuxcnc/pull/90
[10:19:43] <ikcalB> jepler: still idk, I assume that the pullrequest should have been submitted against 2.6?d
[10:20:44] <ikcalB> (what I intended to ask: shall I make a seperate, or not - and shall I delete that req)
[10:24:05] <jepler> Please close the pull request and make at least one new pull request (for the personality= part). you can also make a pull request for the two-pass loadusr thing, but I don't believe we can accept that pull request.
[10:26:00] <ikcalB> I did that already. just - again - not for 2.6 but master.
[10:30:03] <jepler> oh I missed that. I don't think you can change the "merge to" branch in a pull request after creation, so yes I think you'll have to close that one and create a fresh one
[11:55:18] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15ikcalB opened pull request #91: twopass.tcl: add support for personalities (kernel module parameters) (062.6...062.6-tp_personalities) 02
https://github.com/LinuxCNC/linuxcnc/pull/91
[11:55:49] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15ikcalB closed pull request #90: twopass.tcl: add support for `personalities` of kernel modules (06master...06tp-personalities) 02
https://github.com/LinuxCNC/linuxcnc/pull/90
[11:56:20] <ikcalB> jepler: done. this will be merged "up" until master - correct? how could I help you doing this?
[11:58:07] <jepler> ikcalB: have you studied how to write a new test for linuxcnc? I there aren't any tests for two-pass hal files, so adding a test that shows it works right would give confidence in your change
[11:58:54] <jepler> ikcalB: for 2.6 and 2.7 the release manager is seb_kuzminsky so he makes the decision about whether changes go in; for master branch it's more relaxed and uncontroversial stuff is pushed without discussion.
[12:00:27] <ikcalB> this is beyond my skills for now. I'm definetly going to look into this - unfortunately in autumn earliest. have to get final things done here.
[12:04:07] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15ikcalB opened pull request #92: halshow.tcl: use no special grouping for signals (06master...062.6-halshow_signals) 02
https://github.com/LinuxCNC/linuxcnc/pull/92
[12:07:12] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15ikcalB opened pull request #93: halshow.tcl: use no special grouping for signals (062.6...062.6-halshow_signals) 02
https://github.com/LinuxCNC/linuxcnc/pull/93
[12:08:20] * ikcalB is starting to hate github
[12:17:06] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15jepler commented on issue #92: After this change, it appears that 'proc makeNodeSig' would be unused. The PR should delete the whole proc's implementation. 02
https://github.com/LinuxCNC/linuxcnc/pull/92#issuecomment-229110168
[12:17:49] <jepler> also I think that seb_kuzminsky will be reluctant to take this change in 2.6, because it does not fix a regression or a serious bug. it is cosmetic in nature.
[12:31:17] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15ikcalB commented on issue #92: @jepler correct, atm it'd be unused. I'm planning on making (non)groupable strings(items) configurable, and wanted to keep proc for later reference. ... 02
https://github.com/LinuxCNC/linuxcnc/pull/92#issuecomment-229114187
[12:32:20] <ikcalB> jepler: I assume the same is for 2.7? we'd have to manually overwrite it, then
[13:29:13] <jepler> if you want to deploy some version with your custom modifications, then I recommend building your own debian package and distributing it. This recently got better documentation.
http://linuxcnc.org/docs/master/html/code/building-linuxcnc.html#_building_debian_packages
[14:41:48] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15jepler commented on issue #92: Personally, I don't use halshow, so I am not a good person to judge the merits of changes to it. (and I don't really understand what your table is trying to show). If you want to discuss possible enhancements, I recommend the mailing list or forum where you have a higher chance of finding people who do.... 02
https://github.com/LinuxCNC/linuxcnc/pull/92#issuecomment-229152520
[14:48:11] <ikcalB> jepler: tnx, will do so - both!
[14:51:31] <jepler> hah funny variant of that gif somebody posted the other day:
https://svbtleusercontent.com/dyerbwpxmvh7zg_small.png
[14:51:41] <jepler> relevance to the current discussion here: negligible
[14:52:14] <cradek> ha
[14:52:37] <cradek> and I approve of the font
[17:10:40] -linuxcnc-github:#linuxcnc-devel- [13linuxcnc] 15nicokid commented on issue #33: You must also do the update of axisu.glade and axisv.glade. 02
https://github.com/LinuxCNC/linuxcnc/pull/33#issuecomment-229193377
[17:38:10] <KGB-linuxcnc> 03Jeff Epler 05master ef1f6bf 06linuxcnc 10src/emc/usr_intf/stepconf/axisu.glade 10src/emc/usr_intf/stepconf/axisv.glade stepconf: take nicokid's version of these files * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=ef1f6bf
[17:38:28] <KGB-linuxcnc> 03Jeff Epler 05master 99cd0dd 06linuxcnc 10scripts/latency-histogram latency-histogram: set pixel size of window explicitly * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=99cd0dd
[17:38:28] <KGB-linuxcnc> 03Jeff Epler 05master b97a1ca 06linuxcnc 10src/hal/components/panelui.c 10src/hal/components/sampler_usr.c 10src/hal/components/streamer_usr.c streams: set errno before calling perror * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=b97a1ca
[17:50:37] <seb_kuzminsky> jepler:
http://paste.debian.net/769013/ ?
[18:00:50] <jepler> seb_kuzminsky: I thought about that but (A) it has to run in rtai realtime too, where there's probably no extern int errno; and aren't there more exit paths than that?
[18:02:09] <linuxcnc-build> build #2471 of 1405.rip-wheezy-armhf is complete: Failure [4failed compile] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/1405.rip-wheezy-armhf/builds/2471 blamelist: Jeff Epler <jepler@unpythonic.net>
[18:06:06] <jepler> make: *** [.html-images-stamp] Segmentation fault
[18:06:09] <jepler> flake flake flake
[18:09:48] <linuxcnc-build> build #4291 of 0000.checkin is complete: Failure [4failed] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/0000.checkin/builds/4291 blamelist: Jeff Epler <jepler@unpythonic.net>
[18:37:10] <seb_kuzminsky> jepler: that's all the exit paths i'm pretty sure
[18:37:49] <seb_kuzminsky> dont those functions run in the userspacey nonrealtimey part of the world?
[18:38:03] <seb_kuzminsky> bbl
[18:57:54] <jepler> linuxcnc-build: force build --branch=master 0000.checkin
[18:57:59] <linuxcnc-build> The build has been queued, I'll give a shout when it starts
[19:23:07] <linuxcnc-build> build forced [ETA 1h22m46s]
[19:23:07] <linuxcnc-build> I'll give a shout when the build finishes
[21:20:33] <linuxcnc-build> Hey! build 0000.checkin #4293 is complete: Success [3build successful]
[21:20:33] <linuxcnc-build> Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/0000.checkin/builds/4293
[21:21:07] <jepler> halcmd: loadusr -Wn nope hal_manualtoolchange
[21:21:07] <jepler> Waiting for component 'nope' to become ready.
[21:21:08] <jepler> while waiting for coponent 'nope', component 'hal_manualtoolchange' loaded. did you specify the correct component name via loadusr -Wn?...............
[21:21:30] <jepler> I wonder if getting this ^^^ is worth the price, which the way I've implemented it includes converting a big swath of halcmd to C++ (!)
[21:22:07] <seb_kuzminsky> ooh me likey
[21:23:13] <jepler> I should fix the typos
[21:24:03] <jepler> jmk would have my head for putting C++ into his beautiful design
[21:25:55] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 98ccaf7 06linuxcnc 10src/hal/hal_priv.h hal_priv: Introduce, use SHMFIELD * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=98ccaf7
[21:25:55] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 5598a7e 06linuxcnc 10src/hal/hal_priv.h hal_priv: Make it possible to forward-declare these structures * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=5598a7e
[21:25:55] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus b0f6e8c 06linuxcnc 10src/hal/hal_priv.h hal_priv: forward-declare these types * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=b0f6e8c
[21:25:57] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 8107f82 06linuxcnc 10src/hal/hal_priv.h hal_priv: reorder slightly * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=8107f82
[21:26:01] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 455a8cd 06linuxcnc 10src/hal/halmodule.cc halmodule: better check for HAL being initialized * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=455a8cd
[21:26:05] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 32a2499 06linuxcnc 10src/hal/hal_priv.h hal_priv: Type-safe C++ for access to HAL shared memory area * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=32a2499
[21:26:09] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 6ebeaa5 06linuxcnc 10src/hal/utils/halcmd.h 10src/hal/utils/halcmd_commands.h halcmd: Make headers usable from C++ * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=6ebeaa5
[21:26:13] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 5e66f97 06linuxcnc 10src/hal/utils/halcmd.c 10src/hal/utils/halcmd_commands.c 10src/hal/utils/halcmd_commands.h halcmd: const-correctness fixes * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=5e66f97
[21:26:18] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 6aab928 06linuxcnc 10src/hal/utils/halcmd_commands.c halcmd: use SHMFIELD() for next-pointers * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=6aab928
[21:26:22] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus c352d25 06linuxcnc 10src/hal/utils/Submakefile 04src/hal/utils/halcmd_commands.c 03src/hal/utils/halcmd_commands.cc halcmd: convert halcmd_commands to C++ * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=c352d25
[21:26:26] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus d5299a9 06linuxcnc 10src/hal/utils/halcmd_commands.cc halcmd: improve user feedback when loading components * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=d5299a9
[21:26:26] <jepler> .. when writing C++ that gets into low-level hal structures, you can also now write nice clear code like this:
[21:26:29] <jepler> for(auto comp = hal_data->comp_list_ptr; comp; comp=comp->next_ptr) {
[21:26:32] <jepler> result.insert(comp->name);
[21:26:35] <jepler> instead of mucking with SHMOFF and SHMPTR
[21:26:37] <jepler> }
[21:27:03] <jepler> hm I forgot to do a full runtests before pushing, surely at least one thing will turn up...
[21:27:54] <linuxcnc-build> build #1434 of 1903.clang-wheezy-amd64 is complete: Failure [4failed compile] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/1903.clang-wheezy-amd64/builds/1434 blamelist: Jeff Epler <jepler@unpythonic.net>
[21:31:32] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 1f7f56a 06linuxcnc 10src/hal/hal_priv.h hal_priv: Type-safe C++ for access to HAL shared memory area * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=1f7f56a
[21:31:32] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 70d5566 06linuxcnc 10src/hal/utils/halcmd.h 10src/hal/utils/halcmd_commands.h halcmd: Make headers usable from C++ * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=70d5566
[21:31:32] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 7442414 06linuxcnc 10src/hal/utils/halcmd.c 10src/hal/utils/halcmd_commands.c 10src/hal/utils/halcmd_commands.h halcmd: const-correctness fixes * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=7442414
[21:31:35] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 494fbbd 06linuxcnc 10src/hal/utils/halcmd_commands.c halcmd: use SHMFIELD() for next-pointers * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=494fbbd
[21:31:39] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 83ec76d 06linuxcnc 10src/hal/utils/Submakefile 04src/hal/utils/halcmd_commands.c 03src/hal/utils/halcmd_commands.cc halcmd: convert halcmd_commands to C++ * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=83ec76d
[21:31:44] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 7ee79ff 06linuxcnc 10src/hal/utils/halcmd_commands.cc halcmd: improve user feedback when loading components * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=7ee79ff
[21:34:11] <linuxcnc-build> build #4281 of 1306.rip-precise-amd64 is complete: Failure [4failed compile] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/1306.rip-precise-amd64/builds/4281 blamelist: Jeff Epler <jepler@unpythonic.net>
[21:34:29] <linuxcnc-build> build #4279 of 1300.rip-precise-i386 is complete: Failure [4failed compile] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/1300.rip-precise-i386/builds/4279 blamelist: Jeff Epler <jepler@unpythonic.net>
[21:36:43] <linuxcnc-build> build #1433 of 1902.clang-wheezy-rtai-i386 is complete: Failure [4failed compile] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/1902.clang-wheezy-rtai-i386/builds/1433 blamelist: Jeff Epler <jepler@unpythonic.net>
[21:38:03] <jepler> In file included from hal/utils/halcmd.c:68:
[21:38:03] <jepler> hal/utils/../hal_priv.h:306:3: error: redefinition of typedef 'hal_comp_t' is invalid in C [-Wtypedef-redefinition]
[21:38:06] <jepler> } hal_comp_t;
[21:38:06] <jepler> huh it is?
[21:42:27] <mozmck> ooh neat! you won't catch me complaining about using c++ :-) c++11+ adds some nice things
[21:43:19] <linuxcnc-build> build #3490 of 1301.rip-precise-rtai-i386 is complete: Failure [4failed compile] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/1301.rip-precise-rtai-i386/builds/3490 blamelist: Jeff Epler <jepler@unpythonic.net>
[21:43:37] <mozmck> but I bet we can't use much of that because it is probably only supported on the newest platforms we support.
[21:44:34] <jepler> http://wiki.linuxcnc.org/cgi-bin/wiki.pl?MinimumSoftwareVersions For master, our oldest platform has g++-4.7 which has imperfect C++11 support.
https://gcc.gnu.org/gcc-4.7/cxx0x_status.html
[21:53:46] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 9380a21 06linuxcnc 10src/hal/hal_priv.h hal_priv: forward-declare these types * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=9380a21
[21:53:46] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 786f037 06linuxcnc 10src/hal/hal_priv.h hal_priv: reorder slightly * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=786f037
[21:53:46] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus aa65ad3 06linuxcnc 10src/hal/halmodule.cc halmodule: better check for HAL being initialized * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=aa65ad3
[21:53:48] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus c998ceb 06linuxcnc 10src/hal/hal_priv.h hal_priv: Type-safe C++ for access to HAL shared memory area * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=c998ceb
[21:53:52] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 85d58bb 06linuxcnc 10src/hal/utils/halcmd.h 10src/hal/utils/halcmd_commands.h halcmd: Make headers usable from C++ * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=85d58bb
[21:53:56] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus 9c83693 06linuxcnc 10src/hal/utils/halcmd.c 10src/hal/utils/halcmd_commands.c 10src/hal/utils/halcmd_commands.h halcmd: const-correctness fixes * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=9c83693
[21:54:01] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus db6e0ce 06linuxcnc 10src/hal/utils/halcmd_commands.c halcmd: use SHMFIELD() for next-pointers * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=db6e0ce
[21:54:05] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus bdb3f9a 06linuxcnc 10src/hal/utils/Submakefile 04src/hal/utils/halcmd_commands.c 03src/hal/utils/halcmd_commands.cc halcmd: convert halcmd_commands to C++ * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=bdb3f9a
[21:54:10] <KGB-linuxcnc> 03Jeff Epler 05jepler/master/halcmd-cplusplus ab83f39 06linuxcnc 10src/hal/utils/halcmd_commands.cc halcmd: improve user feedback when loading components * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=ab83f39
[21:54:25] <jepler> maybe I can get it to build on all our platforms in only 4 or 9 tries :)
[22:12:27] <linuxcnc-build> build #2440 of 1400.rip-wheezy-i386 is complete: Failure [4failed compile] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/1400.rip-wheezy-i386/builds/2440 blamelist: Jeff Epler <jepler@unpythonic.net>
[22:18:21] <linuxcnc-build> build #2440 of 1403.rip-wheezy-amd64 is complete: Failure [4failed compile] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/1403.rip-wheezy-amd64/builds/2440 blamelist: Jeff Epler <jepler@unpythonic.net>
[22:18:48] <linuxcnc-build> build #2474 of 1405.rip-wheezy-armhf is complete: Failure [4failed compile] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/1405.rip-wheezy-armhf/builds/2474 blamelist: Jeff Epler <jepler@unpythonic.net>
[22:25:44] <linuxcnc-build> build #1950 of 1402.rip-wheezy-rtpreempt-i386 is complete: Failure [4failed compile] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/1402.rip-wheezy-rtpreempt-i386/builds/1950 blamelist: Jeff Epler <jepler@unpythonic.net>
[22:28:24] <mozmck> jepler: so what is the motivation to move parts of hal to c++?
[22:29:50] <linuxcnc-build> build #2639 of 1404.rip-wheezy-rtpreempt-amd64 is complete: Failure [4failed compile] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/1404.rip-wheezy-rtpreempt-amd64/builds/2639 blamelist: Jeff Epler <jepler@unpythonic.net>
[22:38:29] <linuxcnc-build> build #2106 of 1401.rip-wheezy-rtai-i386 is complete: Failure [4failed apt-get-update compile] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/1401.rip-wheezy-rtai-i386/builds/2106 blamelist: Jeff Epler <jepler@unpythonic.net>
[22:59:56] <linuxcnc-build> build #4294 of 0000.checkin is complete: Failure [4failed] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/0000.checkin/builds/4294 blamelist: Jeff Epler <jepler@unpythonic.net>