Back
[17:28:21] <KGB-linuxcnc> 03Chris Radek 052.6 2c60cbd 06linuxcnc 10src/emc/rs274ngc/interp_convert.cc Clear saved state from previous NURBSes to avoid bogus motion * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=2c60cbd
[17:28:22] <KGB-linuxcnc> 03Chris Radek 052.6 5cef5c3 06linuxcnc 10src/emc/task/emccanon.cc NURBS: fix biarc G1 continuity * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=5cef5c3
[17:29:14] <cradek> ... but this is not what I set out to fix
[17:32:32] <cradek> but the wrong path is much smoother now
[17:36:45] <cradek> crap, those probably should've gone in 2.5
[18:35:19] <KGB-linuxcnc> 03Chris Radek 05v2.5_branch 3ac214f 06linuxcnc 10src/emc/rs274ngc/interp_convert.cc Clear saved state from previous NURBSes to avoid bogus motion * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=3ac214f
[18:35:19] <KGB-linuxcnc> 03Chris Radek 05v2.5_branch 0057947 06linuxcnc 10src/emc/task/emccanon.cc NURBS: fix biarc G1 continuity * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=0057947
[18:35:19] <KGB-linuxcnc> 03Chris Radek 052.6 6559a3b 06linuxcnc Merge branch 'v2.5_branch' into 2.6 * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=6559a3b
[18:35:34] * cradek <- git newbie
[18:43:24] <skunkworks_> hmm Preprocessing wj200_vfd.comp
[18:43:25] <skunkworks_> make: ../bin/comp: Command not found
[18:43:27] <skunkworks_> make: *** [hal/user_comps/wj200_vfd/wj200_vfd.c] Error 127
[18:43:28] <skunkworks_> make: *** Waiting for unfinished jobs....
[18:43:45] <skunkworks_> v2.6.0-pre3-59-g49bfb96
[18:43:50] <cradek> I fixed that a couple days back
[18:43:58] <skunkworks_> I just pulled it.
[18:44:37] <cradek> oh you're on master
[18:44:40] <cradek> lemme make you a merge
[18:45:32] <KGB-linuxcnc> 03Chris Radek 05master 2f1f044 06linuxcnc Merge branch '2.6' * 14http://git.linuxcnc.org/?p=linuxcnc.git;a=commitdiff;h=2f1f044
[18:45:50] <cradek> pull again - that'll fix it
[18:50:21] <skunkworks_> that worked!
[18:50:27] <cradek> yay
[18:50:28] <skunkworks_> that worked!
[18:57:32] <cradek> oh wow
[18:57:44] <cradek> I think there's an error case we don't catch...
[18:57:57] <cradek> g0 x0 y0 / g5.1 i0 j0 x1 y1 f999
[19:21:46] <linuxcnc-build> build #2128 of 1300.rip-precise-i386 is complete: Failure [4failed compile runtests] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/1300.rip-precise-i386/builds/2128 blamelist: Chris Radek <chris@timeguy.com>
[19:45:37] <linuxcnc-build> build #2132 of 0000.checkin is complete: Failure [4failed] Build details are at
http://buildbot.linuxcnc.org/buildbot/builders/0000.checkin/builds/2132 blamelist: Chris Radek <chris@timeguy.com>
[20:39:21] <skunkworks_> cradek: is your fixes in master?
[20:43:39] <cradek> yep
[20:46:20] <skunkworks_> ok. so reading your email - I thought it would follow better - but maybe not?
[20:47:40] <skunkworks_> http://imagebin.org/312425
[20:57:47] <skunkworks_> reading comprehension isn't my strong point... I think I was reading 'smooth' as better path following
[21:28:30] <cradek> if you compare before and after you'll see a big smoothness difference
[21:28:39] <cradek> the old path had pointy spots
[21:30:20] <cradek> (as an aside: I think this path would be easier to make with lines and arcs)
[21:32:33] <cradek> you can barely see it in
http://ibin.co/1OCw5gNzXQBF
[21:33:02] <cradek> at the left top of that topmost loop, you can see an inflection point where it changes from concave up to concave down
[21:33:20] <cradek> it's very evident if you zoom
[21:33:45] <cradek> half the arcs in the path were just totally wrong
[21:36:37] <skunkworks_> yeck
[21:53:00] <cradek> I don't understand that runtest failure
[21:54:27] <cradek> I truly doubt I broke that
[22:01:00] <skunkworks_> your name is on it... ;)
[22:01:46] <cradek> haha no, seb's name is on it - you just aren't reading it quite right
[22:07:21] <skunkworks_> heh